Geronimo
  1. Geronimo
  2. GERONIMO-2290

Percent complete goes over 100% when installing configurations

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Critical Critical
    • Resolution: Unresolved
    • Affects Version/s: 1.1
    • Fix Version/s: 2.0.3
    • Component/s: console, core
    • Security Level: public (Regular issues)
    • Labels:
      None

      Description

      Looks like the UnpackArtifactTypeHandler counts the "uncompressed" bytes, whereas the % is based on the content size returned by the server for the download (the "compressed" byte count).

      Probably should use an InputStream between the download stream and the ZIP stream that performs the count on read(byte[],int,int) and them use that count instead of the uncompressed count.

        Issue Links

          Activity

          Hide
          Aaron Mulder added a comment -

          Someone applied a fix to always count the unnpacked bytes of a JAR but...

          We have yet another problem with this issue, which is that packed artifacts should used the file size, whereas artifacts that are going to be unpacked should use the size of the contents. We currently unpack CARs but leave JARs packed.

          Workaround applied to 1.1 but not applying to trunk because this really ought to be reconsidered in light of GERONIMO-2288 (if we're going to change the way we decide whether to unpack, we should also change when we do the size calculation so we only do it if we're going to unpack the artifact anyway).

          Show
          Aaron Mulder added a comment - Someone applied a fix to always count the unnpacked bytes of a JAR but... We have yet another problem with this issue, which is that packed artifacts should used the file size, whereas artifacts that are going to be unpacked should use the size of the contents. We currently unpack CARs but leave JARs packed. Workaround applied to 1.1 but not applying to trunk because this really ought to be reconsidered in light of GERONIMO-2288 (if we're going to change the way we decide whether to unpack, we should also change when we do the size calculation so we only do it if we're going to unpack the artifact anyway).

            People

            • Assignee:
              Unassigned
              Reporter:
              Aaron Mulder
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Development