[GERONIMO-2288] Abstract/Maven repositories install modules incorrectly

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.1, 1.1.1, 1.2, 2.0-M6
• Fix Version/s: 2.0.3
• Component/s: kernel, Plugins
• Security Level: public (Regular issues)
• Assignee: Aaron Mulder
• Reporter: Aaron Mulder
• Created: 07/Aug/06 14:56
• Updated: 04/Feb/09 18:01

Description

The repository unpacks a JAR when it installs it only if the Artifact type is "car". That is incorrect – it should unpack any module with META-INF/config.ser (which is the logic that we use in other places, such as RepositoryConfigurationStore). This breaks plugins that don't have the type "car" (such as copying a database pool from server to server).

The currently handling attempts to be generic by associating a behavior with each file type, though in practice this is only used for type=car. In the 1.1 branch, I am going to put in a workaround to look up the "car" handler any time we find a META-INF/config.ser (a pretty minimal workaround).

In trunk, I think we should remove the behavior/type association and instead have a boolean for whether configurations should be unpacked, or an "ArtifactTypeHandler" property specifically for configurations and another one for non-configurations. I don't see any reason to distinguish based on module type. Input would be appreciated for the 1.2 resolution.

Issue Links

• blocks: GERONIMO-2290 Percent complete goes over 100% when installing configurations
• blocks: GERONIMO-2289 GeronimoAsMavenServlet.java generates wrong default-repository element
• is a clone of: GERONIMO-2258 Abstract/Maven repositories install modules incorrectly
• is duplicated by: GERONIMO-2160 Can't install a J2EE connector plugin