Geronimo
  1. Geronimo
  2. GERONIMO-2227

ENC Lookup Fix (include parent modules)

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.1
    • Fix Version/s: Wish List
    • Component/s: naming
    • Security Level: public (Regular issues)
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      I ran across this while working on plugins that use resource-ref-like features to identify a database connection pool, JMS destination, etc.

      The problem was that some naming searches were restricted to the current module only when I felt all parents should be searched too.

      I would like David J to review this before I commit it, as my understanding of the code in question is not terribly thorough.

        Activity

        Hide
        David Jencks added a comment -

        Don't see how to progress without more info...

        Show
        David Jencks added a comment - Don't see how to progress without more info...
        Hide
        Aaron Mulder added a comment -

        Unfortunately, I don't have an example. This change was left on my tree and I've forgotten specifically what I ran into to cause me to do it. I do remember that I ended up debugging extensively and finally found that the commented-out line was causing the wrong module to be searched, but that's already in there and I can't remember what the new changes were addressing.

        I guess we better put this on hold until I can recreate the problem.

        Show
        Aaron Mulder added a comment - Unfortunately, I don't have an example. This change was left on my tree and I've forgotten specifically what I ran into to cause me to do it. I do remember that I ended up debugging extensively and finally found that the commented-out line was causing the wrong module to be searched, but that's already in there and I can't remember what the new changes were addressing. I guess we better put this on hold until I can recreate the problem.
        Hide
        David Jencks added a comment -

        Maybe I'm missing something, but you patch appears to assign null to an already null variable. It also doesn't address the issue of looking in parents. I also don't understand where the line

        • //moduleURI = linkName.substring(0, pos);

        you are proposing to remove came from and think that it would be correct. The idea is that is you specify

        j2ee-module#admin-object-name

        we will only look in that particular j2ee module, not some other that might have a similarly named admin object.

        Do you have an sample to show the problem you are trying to solve?

        Show
        David Jencks added a comment - Maybe I'm missing something, but you patch appears to assign null to an already null variable. It also doesn't address the issue of looking in parents. I also don't understand where the line //moduleURI = linkName.substring(0, pos); you are proposing to remove came from and think that it would be correct. The idea is that is you specify j2ee-module#admin-object-name we will only look in that particular j2ee module, not some other that might have a similarly named admin object. Do you have an sample to show the problem you are trying to solve?

          People

          • Assignee:
            Aaron Mulder
            Reporter:
            Aaron Mulder
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development