Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
1.1, 1.2
-
Security Level: public (Regular issues)
-
None
Description
This patch fixes a pretty obvious NPE source:
Index: modules/system/src/java/org/apache/geronimo/system/repository/Maven1Repository.java
===================================================================
— modules/system/src/java/org/apache/geronimo/system/repository/Maven1Repository.java (revision 413322)
+++ modules/system/src/java/org/apache/geronimo/system/repository/Maven1Repository.java (working copy)
@@ -66,16 +66,18 @@
path = new File(path, query.getType() + "s");
File[] files = path.listFiles();
- for (int i = 0; i < files.length; i++) {
- File file = files[i];
- String fileName = file.getName();
- if (fileName.startsWith(query.getArtifactId() + "-") && fileName.endsWith("." + query.getType())) {
- String version = fileName.substring(query.getArtifactId().length() + 1);
- version = version.substring(0, version.length() - 1 - query.getType().length());
- if(query.getVersion() != null && !query.getVersion().toString().equals(version)) {
- continue;
+ if (files != null) {
+ for (int i = 0; i < files.length; i++) {
+ File file = files[i];
+ String fileName = file.getName();
+ if (fileName.startsWith(query.getArtifactId() + "-") && fileName.endsWith("." + query.getType()))Unknown macro: {+ String version = fileName.substring(query.getArtifactId().length() + 1);+ version = version.substring(0, version.length() - 1 - query.getType().length());+ if(query.getVersion() != null && !query.getVersion().toString().equals(version)) { + continue; + }+ artifacts.add(new Artifact(query.getGroupId(), query.getArtifactId(), version, query.getType())); } - artifacts.add(new Artifact(query.getGroupId(), query.getArtifactId(), version, query.getType()));
}
}
} else {