Geronimo
  1. Geronimo
  2. GERONIMO-1907

Deploy command should redeploy if the app is already deployed

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Won't Fix
    • Affects Version/s: 1.1
    • Fix Version/s: 2.0.3
    • Component/s: deployment, usability
    • Security Level: public (Regular issues)
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      Attached patch, and changing fix version to 1.2. Also unassigning so that committers can review and update.

      1. redeploy.patch
        5 kB
        Rakesh Midha

        Activity

        Hide
        Jay D. McHugh added a comment -

        When an app is undeployed (as part of a redeploy) any other apps that depend on it are stopped.

        Trying to track down all apps that depend on the current app so that they can be automatically restarted is too much effort to expend in the 2.0.x branch.

        If there is sufficient interest - a new JIRA should be opened in a more current/active branch.

        Show
        Jay D. McHugh added a comment - When an app is undeployed (as part of a redeploy) any other apps that depend on it are stopped. Trying to track down all apps that depend on the current app so that they can be automatically restarted is too much effort to expend in the 2.0.x branch. If there is sufficient interest - a new JIRA should be opened in a more current/active branch.
        Hide
        Dario Andrade added a comment -

        I think deploy tool should throw an error when trying to deploy to an existing configuration.

        redeploy command should be used so user is sure what he's doing.

        moreover, undeploy and deploy should do it too.

        but should never redeploy an application, IMHO


        Dario Andrade

        Show
        Dario Andrade added a comment - I think deploy tool should throw an error when trying to deploy to an existing configuration. redeploy command should be used so user is sure what he's doing. moreover, undeploy and deploy should do it too. but should never redeploy an application, IMHO – Dario Andrade
        Hide
        Matt Hogstrom added a comment -

        Moving to 2.0.x

        Show
        Matt Hogstrom added a comment - Moving to 2.0.x
        Hide
        Vamsavardhana Reddy added a comment -

        I think we should retain both deploy and redeploy commands as they are right now and provide an "override" option so that deploy command redeploys and redeploy command deploys if necessary.

        Show
        Vamsavardhana Reddy added a comment - I think we should retain both deploy and redeploy commands as they are right now and provide an "override" option so that deploy command redeploys and redeploy command deploys if necessary.
        Hide
        Rakesh Midha added a comment -


        We can if we want to it, but I think this need to be decided by community.

        Show
        Rakesh Midha added a comment - We can if we want to it, but I think this need to be decided by community.
        Hide
        Vamsavardhana Reddy added a comment -

        Shoule we eliminate redeploy altogether as deploy will anyway redeploy whereever necessary!!

        Show
        Vamsavardhana Reddy added a comment - Shoule we eliminate redeploy altogether as deploy will anyway redeploy whereever necessary!!
        Hide
        Rakesh Midha added a comment -

        In CommandDistribute, before deploying and application check if the application with same targetID exists. If it exists instead of distributing and starting, redeploy it.

        Added private method checkExisting() to find if the application is already deployed.. This code requires to use getCommand() method of DeployTool.java which was private, made it public for command redirection.

        Show
        Rakesh Midha added a comment - In CommandDistribute, before deploying and application check if the application with same targetID exists. If it exists instead of distributing and starting, redeploy it. Added private method checkExisting() to find if the application is already deployed.. This code requires to use getCommand() method of DeployTool.java which was private, made it public for command redirection.

          People

          • Assignee:
            Jay D. McHugh
            Reporter:
            Aaron Mulder
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development