[GEOMETRY-10] Reuse Normalized Vectors

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Done
• Fix Version/s: 1.0
• Assignee: Unassigned
• Reporter: Matt Juntunen
• Created: 05/Jun/18 02:55
• Updated: 03/Jan/20 16:53
• Resolved: 18/Sep/18 02:56

Description

The Vector.normalize() method is used quite frequently. We currently always return a new instance with each method call, but we should be able to reuse the current instance if it is already normalized. 

Ex:

public Vector3D normalize() {
   final double normSq = getNormSq();
   if (normSq == 1.0) {
      return this;
   }
   else if (normSq == 0.0) {
      throw new IllegalStateException(ZERO_NORM_MSG);
   }

   return scalarMultiply(1 / Math.sqrt(normSq);
}

We'll need to verify that this won't introduce any floating point accuracy issues.

 

Pull request: https://github.com/apache/commons-geometry/pull/10