[GEODE-9630] Gateway sender has public setter methods that should not be exposed

• Type: Improvement
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.15.0
• Fix Version/s: 1.15.0
• Component/s: wan
• Labels: pull-request-available
• Assignee: Owen Nichols
• Reporter: Udo Kohlmeyer
• Created: 23/Sep/21 00:57
• Updated: 22/Jun/22 20:46
• Resolved: 07/Oct/21 00:50

Description

Looking at the GatewaySender interface I noticed there are numerous public setter methods. Geode should not allow for the ability to directly change GatewaySender functionality without proper process.

This is largely to avoid the introduction of side effects into the system. A prime example of this is, the ability to call `setGroupTransactionEvents`, which from what I understand should NEVER be allowed to be changed in just 1 server instead of cluster-wide. This by writing a function and changing the setting on only 1 server can run the risk of the whole system behaving incorrectly causing failures which would be close to impossible to track down.

Issue Links

• relates to: GEODE-9629 GatewaySender.setRetriesToGetTransactionEventsFromQueue on public API
• links to: GitHub Pull Request #6939