[GEODE-9598] processEventAndDeliverConflatable in clientRegistrationEventQueueManager unnecessarily adds same client routing information to the existing HAEventWrapper

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.12.0
• Component/s: client queues
• Labels: GeodeOperationAPI
• Assignee: Unassigned
• Reporter: Eric Shu
• Created: 14/Sep/21 01:27
• Updated: 14/Sep/21 23:25

Description

In processEventAndDeliverConflatable method, following code is executed.

          if (filterRoutingInfo != null) {
            FilterRoutingInfo.FilterInfo filterInfo = filterRoutingInfo.getLocalFilterInfo();

            if (filterInfo != null) {
              ClientUpdateMessageImpl clientUpdateMessage = conflatable instanceof HAEventWrapper
                  ? (ClientUpdateMessageImpl) ((HAEventWrapper) conflatable)
                      .getClientUpdateMessage()
                  : (ClientUpdateMessageImpl) conflatable;

              internalCacheEvent.setLocalFilterInfo(filterInfo);

              Set<ClientProxyMembershipID> newFilterClientIDs =
                  cacheClientNotifier.getFilterClientIDs(internalCacheEvent, filterProfile,
                      filterInfo,
                      clientUpdateMessage);

In cacheClientNotifier.getFilterClientIDs method, each client information is added again to the HAEventWrapper. It is unnecessary. Instead, it should only find the client this cacheClientProxy is for, and only add that client info into the HAEventWrapper.