[GEODE-9404] Should not log "No information for senderId: " if the node processing the tx does not have sender configured - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.14.0
Fix Version/s: 1.14.0, 1.15.0
Component/s: transactions
Labels:

Description

In serial wan setting, not all nodes have the sender configured. These error logging should not be logged. But currently it is logged for every tx operation if the the node does not have sender configured (which is a normal case for serail wan).

The following stack shows where it was logged.
org.apache.geode.internal.cache.TXLastEventInTransactionUtils.checkNoSendersGroupTransactionEvents(TXLastEventInTransactionUtils.java:81)
at org.apache.geode.internal.cache.TXLastEventInTransactionUtils.getLastTransactionEvent(TXLastEventInTransactionUtils.java:45)
at org.apache.geode.internal.cache.TXState.firePendingCallbacks(TXState.java:250)
at org.apache.geode.internal.cache.TXState.commit(TXState.java:544)
at org.apache.geode.internal.cache.TXStateProxyImpl.commit(TXStateProxyImpl.java:237)
at org.apache.geode.internal.cache.TXManagerImpl.commit(TXManagerImpl.java:444)

private static boolean checkNoSendersGroupTransactionEvents(List<EntryEventImpl> callbacks,
      Cache cache) throws ServiceConfigurationError {
    for (String senderId : getSenderIdsForEvents(callbacks)) {
      GatewaySender sender = cache.getGatewaySender(senderId);
      if (sender == null) {
        logger.error("No sender found for {}", senderId, new Exception());
        throw new ServiceConfigurationError("No information for senderId: " + senderId);
      }
      if (sender.mustGroupTransactionEvents()) {
        return false;
      }
    }
    return true;
  }