[GEODE-9380] Replace sleep()s from Nio.SslEngine replace with yields

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.12.4, 1.13.4, 1.14.0, 1.15.0
• Component/s: membership
• Labels: pull-request-available
• Assignee: Kamilla Aslami
• Reporter: Ernest Burghardt
• Created: 14/Jun/21 16:45
• Updated: 30/Jul/21 22:26
• Resolved: 24/Jun/21 16:22

Description

We noticed a 4-5x increase in the worst-case P2P send latency (most notably sendReplication) in 1.12 vs 1.8. Further analysis showed that the increase in sendReplicationTime is related to how long it takes to create the sender connection. More specifically, all the time spent creating the sender is in the handshake. Experiments with various sleep durations in NioSslEngine.handshake() method showed that this issue can be fixed by replacing both sleeps handshake() method with Thread.yield() calls.

Issue Links

• relates to: GEODE-9382 Create Perf test for Nio.SslEngine using yields
• links to: GitHub Pull Request #6615
• links to: GitHub Pull Request #6655
• links to: GitHub Pull Request #6656
• links to: GitHub Pull Request #6657