[GEODE-9342] Handle a double reply of "inf" in the same way as Redis

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.15.0
• Fix Version/s: 1.15.0
• Component/s: redis
• Labels: pull-request-available
• Assignee: Ray Ingles
• Reporter: Sarah Abbey
• Created: 02/Jun/21 21:15
• Updated: 22/Jun/22 20:46
• Resolved: 29/Jun/21 02:14

Description

Currently, in `Coder.java` `stringToDouble` and `doubleToString` methods, we return "Infinity" or "-Infinity", but native Redis returns "inf" or "-inf" respectively, as seen in `networking.c`:

void addReplyDouble(client *c, double d) {
    char dbuf[128], sbuf[128];
    int dlen, slen;
    if (isinf(d)) {
        /* Libc in odd systems (Hi Solaris!) will format infinite in a
         * different way, so better to handle it in an explicit way. */
        addReplyBulkCString(c, d > 0 ? "inf" : "-inf");
    } else {
        dlen = snprintf(dbuf,sizeof(dbuf),"%.17g",d);
        slen = snprintf(sbuf,sizeof(sbuf),"$%d\r\n%s\r\n",dlen,dbuf);
        addReplyString(c,sbuf,slen);
    }
}

We should return "inf" or "-inf" like native Redis.

Issue Links

• links to: GitHub Pull Request #6658