[GEODE-9132] PR clear to take locks on all buckets unconditionally.

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: regions
• Labels: GeodeOperationAPI pull-request-available
• Assignee: Blake Bender
• Reporter: Anilkumar Gingade
• Created: 07/Apr/21 22:13
• Updated: 08/Jun/22 22:43
• Resolved: 26/Apr/21 17:09

Description

Existing behavior:
PR clear employs two different locking behavior based on the presence of client subscription and cache-listeners. If there is no subscription or cache-listener it takes the bucket locks on local nodes else it will send a message to take locks on all buckets before doing the clear.

Expected behavior:
To keep the code/behavior simple PR clear to employ single locking behavior. It will take the lock on all buckets before doing clear irrespective of subscription or cache-listener presence.

Solution:
Remove the following check that drives taking lock on local nodes:

boolean acquireClearLockForNotification =
          (partitionedRegion.hasAnyClientsInterested() || partitionedRegion.hasListener());

And it will call:

obtainLockForClear(regionEvent);

Also remove the logic taking lock in individual nodes in:
DistributedRegion.obtainWriteLocksForClear()
Remove:
if (!localLockedAlready)

{ lockLocallyForClear(getDistributionManager(), getMyId(), regionEvent); }

Issue Links

• links to: GitHub Pull Request #6299
• links to: GitHub Pull Request #6310
• links to: GitHub Pull Request #6333
• links to: GitHub Pull Request #6334
• links to: GitHub Pull Request #6542