Uploaded image for project: 'Geode'
  1. Geode
  2. GEODE-9128

Remove host name look-up from JGAddress

    XMLWordPrintableJSON

    Details

      Description

      The method JGAddress.toString() contains a host name lookup that should be removed. It should just log the toString of its ip_addr field, not ip_addr.getHostName(). That method can cause a reverse-DNS lookup, which is needlessly expensive for a toString() operation.

      
      

      public String toString() {
      StringBuilder sb = new StringBuilder();

      if (ip_addr == null)
      sb.append("<null>");
      else

      { sb.append(ip_addr.getHostName()); }

      if (vmViewId >= 0)

      { sb.append("<v").append(vmViewId).append('>'); }

      if (SHOW_UUIDS)

      { sb.append("(").append(toStringLong()).append(")"); }

      else if (mostSigBits == 0 && leastSigBits == 0)

      { sb.append("(no uuid set)"); }

      sb.append(":").append(port);
      return sb.toString();
      }

      
      

        Attachments

          Activity

            People

            • Assignee:
              bschuchardt Bruce J Schuchardt
              Reporter:
              bschuchardt Bruce J Schuchardt
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: