[GEODE-8972] remove shunnedMembers collection from GMSMembership

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.14.0, 1.15.0
• Component/s: membership
• Labels: pull-request-available
• Assignee: Kamilla Aslami
• Reporter: Bruce J Schuchardt
• Created: 24/Feb/21 21:16
• Updated: 03/Sep/21 02:21
• Resolved: 13/Mar/21 00:50

Description

GMSMembership has a shunnedMembers collection that is used to track the IDs of nodes that are no longer part of the cluster. This collection is no longer needed since we can tell if a node is old by comparing the view ID in its identifier to that of the current view (called latestView in that class. Checks like this are already in place in some parts of the code.

All uses of shunnedMembers should be replaced with this check.

MembershipView<ID> view = latestView;
boolean shunned = memberId.getVmViewId() <= view.getViewId() && !view.contains(memberId);

Issue Links

• links to: GitHub Pull Request #6089