Uploaded image for project: 'Geode'
  1. Geode
  2. GEODE-8789

Inconsistent logging when using BaseCommand.writeRegionDestroyedEx() leads to region name being repeated.

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

      Description

      The method BaseCommand.writeRegionDestroyedEx() takes a String "title" and String "regionName" and uses them to construct an exception message. However, some areas of code that call this method format the "title" String to already contain the region name, leading to the name being logged twice and potentially causing confusion. Calls to this method should be changed to not include the region name in the "title" String.

      protected static void writeRegionDestroyedEx(Message msg, String regionName, String title,
            ServerConnection serverConnection) throws IOException {
          String reason = serverConnection.getName() + ": Region named " + regionName + title;
          RegionDestroyedException ex = new RegionDestroyedException(reason, regionName);
          if (serverConnection.getTransientFlag(REQUIRES_CHUNKED_RESPONSE)) {
            writeChunkedException(msg, ex, serverConnection);
          } else {
            writeException(msg, ex, false, serverConnection);
          }
        }
      

        Attachments

          Activity

            People

            • Assignee:
              donalevans Donal Evans
              Reporter:
              donalevans Donal Evans

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment