[GEODE-8765] NullPointerException if group-transaction-events enabled and mix of puts with transactions and without transactions

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.14.0
• Fix Version/s: 1.14.0
• Component/s: wan
• Labels: pull-request-available
• Assignee: Alberto Gomez
• Reporter: Alberto Gomez
• Created: 03/Dec/20 10:54
• Updated: 03/Sep/21 02:21
• Resolved: 14/Dec/20 10:15

Description

When group-transaction-events is enabled and Geode receives a mix of puts, some inside transactions and some not in transactions, in the case it is needed to add extra events to the batch in order to have all the events for each transaction in the given batch, if the sender runs into an event not belonging to a transaction while looking for events in the queue, a NullPointerException is thrown when trying to get the transactionId for the event. The exception is caught by the sender processor and a warning message is written in the log but some undesired effects are provoked:

 

• In parallel gateway senders, this situation provokes that the batch is sent without completing the transactions and also some events are left in the queues forever without ever being drained (although all the events are sent to the other side).
• In serial gateway senders, this situation provokes that once the exception is thrown, no more events are sent to the other side as the events in the last batch that could not be sent because the exception was thrown are tried to be sent over and over without success.

Issue Links

• links to: GitHub Pull Request #5829