[GEODE-8674] CLI DataInput object leaks internal buffer when allocating ctor is called

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.14.0
• Component/s: native client
• Assignee: Blake Bender
• Reporter: Blake Bender
• Created: 29/Oct/20 23:20
• Updated: 23/Jul/21 17:53
• Resolved: 04/Nov/20 20:20

Description

The CLI DataInput object has two ctors, one of which copies the passed-in buffer parameter via new[] and one of which doesn't.  In the event that the former is called, the buffer is leaked when the object is deleted/Disposed.  Here's the current code for CLI `DataInput::~DataInput`:

```

~DataInput( ) { Cleanup(); }

```

And the code for `DataInput::Cleanup`:

```

      void DataInput::Cleanup()

     

{         //TODO:         //GF_SAFE_DELETE_ARRAY(m_buffer);       }

```

So apparently this bug has been known for some time (?!?), but has never been fixed.