[GEODE-8670] ReconnectDUnitTest is hiding a NullPointerException

• Type: Test
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.14.0
• Fix Version/s: 1.14.0
• Component/s: membership, tests
• Labels: pull-request-available
• Assignee: Bruce J Schuchardt
• Reporter: Jens Deppe
• Created: 29/Oct/20 13:03
• Updated: 03/Sep/21 02:24
• Resolved: 16/Nov/20 15:58

Description

Since working on GEODE-8609, I found that the regex in ReconnectDUnitTest is incorrect. Specifically it looks like this:

    IgnoredException.addIgnoredException("ForcedDisconnectException||Possible loss of quorum");

When removing the double pipe (||) various test methods fail with a NullPointerException. For example:

java.lang.AssertionError: Suspicious strings were written to the log during this run.
Fix the strings or use IgnoredException.addIgnoredException to ignore.
-----------------------------------------------------------------------
Found suspect string in 'dunit_suspect-vm1.log' at line 692

[fatal 2020/10/29 05:59:26.027 PDT <Location services restart thread> tid=203] Uncaught exception in thread Thread[Location services restart thread,5,RMI Runtime]
java.lang.NullPointerException
	at org.apache.geode.distributed.internal.InternalLocator.attemptReconnect(InternalLocator.java:1108)
	at org.apache.geode.distributed.internal.InternalLocator.lambda$launchRestartThread$4(InternalLocator.java:1070)
	at java.lang.Thread.run(Thread.java:748)

There is also an additional DistributedSystemDisconnectedException which probably just requires an addition to the other ignored exceptions.

Issue Links

• links to: GitHub Pull Request #5744