[GEODE-8609] Create a dunit suspect file per VM

• Type: Test
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.14.0, 1.15.0
• Component/s: tests
• Labels: blocks-1.14.0​ pull-request-available
• Assignee: Jens Deppe
• Reporter: Jens Deppe
• Created: 14/Oct/20 18:07
• Updated: 20/Jul/21 16:14
• Resolved: 20/Jul/21 16:13

Description

In some situations, especially when restarting Dunit VMs, it appears that the suspect log file can be corrupted since suspect processing reports errors such as:

org.apache.geode.redis.internal.executor.CrashAndNoRepeatDUnitTest > classMethod FAILED
    java.lang.AssertionError: Suspicious strings were written to the log during this run.
    Fix the strings or use IgnoredException.addIgnoredException to ignore.
    -----------------------------------------------------------------------
    Found suspect string in log4j at line 19594      /home/geode/.gradle/caches/modules-2/files-2.1/antlr/antlr/2.7.7/83cd2cd674a21[warn 2020/10/11 15:23:24.988 GMT <GeodeRedisServer-Command-2> tid=105] Execution of Redis command APPEND append-key-1 -append-key-1-17484-  failed: org.apache.geode.cache.execute.FunctionException: org.apache.geode.cache.execute.FunctionInvocationTargetException: memberDeparted event for < 172.17.0.20(server-3:2004)<v15>:41003 > crashed, true

Where the suspected string is corrupted.

The proposed fix will create a new dunit_suspect log for each VM. The logs will now be named dunit_suspect-vm<VMID>.log. The locator vm and the test runner vm will have logs named dunit_suspect-locator.log and dunit_suspect-local.log respectively.

Issue Links

• links to: GitHub Pull Request #5625
• links to: GitHub Pull Request #6526
• links to: GitHub Pull Request #6705