[GEODE-8602] locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted fails because test doesn't wait for view to have all members

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.14.0
• Fix Version/s: 1.14.0
• Component/s: membership, tests
• Labels: pull-request-available
• Assignee: Dan Smith
• Reporter: Bill Burcham
• Created: 12/Oct/20 17:56
• Updated: 03/Sep/21 02:21
• Resolved: 14/Oct/20 22:32

Description

MembershipIntegrationTest.locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted() correctly waits for locators to start but then fails to wait for locators' views to be updated.

This code:

    assertThat(membership0.getView().getMembers()).hasSize(2);

…doesn't wait. This results in an exception sometimes:

org.apache.geode.distributed.internal.membership.gms.MembershipIntegrationTest > locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted FAILED
    java.lang.AssertionError: 
    Expected size:<2> but was:<1> in:
    <[172.17.0.30(1:locator)<ec><v0>:41000]>
        at org.apache.geode.distributed.internal.membership.gms.MembershipIntegrationTest.locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted(MembershipIntegrationTest.java:308)

A Band-Aid would be to put an awaitility call around the two such hasSize() calls. A better fix would be to make the test deterministic per GEODE-8589.

Issue Links

• relates to: GEODE-8589 make locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted test deterministic
• links to: GitHub Pull Request #5617