[GEODE-8580] Improper use of throw in new C++ test framework - ASF JIRA

XML

Word

Printable

JSON

The new C++ test framework (cppcache/integration/framework) throws pointers to exceptions. This is never a good idea. https://stackoverflow.com/questions/10948316/throw-new-stdexception-vs-throw-stdexception

Although you can catch pointers, it's not recommended practice.

Note: The particular error I ran into was in GfshExecute::execute, where

throw new GfshExecuteException("gfsh error", exit_code);

was being used. This requires gtest to use:

EXPECT_THROW(gfsh.query(query_stmt).execute(), GfshExecuteException*);

links to

GitHub Pull Request #670