[GEODE-8328] CI failure: GfshRuleIntegrationTest fails on Windows

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.14.0
• Component/s: tests
• Assignee: Kirk Lund
• Reporter: Kirk Lund
• Created: 02/Jul/20 19:43
• Updated: 03/Sep/21 02:21
• Resolved: 06/Jul/20 16:11

Description

Since I'm the one that just merged this change, I know it's a simple/easy fix. I forgot to test on Windows before committing the last few tweaks to the PR's branch. If the OS is windows, the test needs to add .bat to the end of the gfsh binary string.

org.apache.geode.test.junit.rules.GfshRuleIntegrationTest > gfshCurrentRuleUsesCurrentGfsh FAILED
    org.junit.ComparisonFailure: expected:<...pache-geode\\bin\\gfsh[]> but was:<...pache-geode\\bin\\gfsh[.bat]>
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        at org.apache.geode.test.junit.rules.GfshRuleIntegrationTest.gfshCurrentRuleUsesCurrentGfsh(GfshRuleIntegrationTest.java:66)

org.apache.geode.test.junit.rules.GfshRuleIntegrationTest > gfsh130RuleUses130Gfsh FAILED
    org.junit.ComparisonFailure: expected:<...geode-1.3.0\\bin\\gfsh[]> but was:<...geode-1.3.0\\bin\\gfsh[.bat]>
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        at org.apache.geode.test.junit.rules.GfshRuleIntegrationTest.gfsh130RuleUses130Gfsh(GfshRuleIntegrationTest.java:72)

CI link: http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0207/test-results/integrationTest/1593718655/

Issue Links

• links to: GitHub Pull Request #5345