[GEODE-8302] WAN Conflation stats are being incorrectly incremented

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.14.0
• Fix Version/s: 1.14.0
• Component/s: statistics, wan
• Assignee: Alberto Gomez
• Reporter: Donal Evans
• Created: 25/Jun/20 19:26
• Updated: 03/Sep/21 02:23
• Resolved: 13/Jul/20 19:40

Description

When the below diff (which adds checks to confirm that conflation stats are not incremented in WAN tests with conflation disabled) is applied, the modified tests fail due to conflation stats being incorrectly incremented. This behaviour is only observed since the changes included in this PR were introduced: https://github.com/apache/geode/pull/4928

diff --git a/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/SerialWANStatsDUnitTest.java b/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/SerialWANStatsDUnitTest.java
index b2ed76728f..bc6beb0002 100644
--- a/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/SerialWANStatsDUnitTest.java
+++ b/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/SerialWANStatsDUnitTest.java
@@ -209,6 +209,7 @@ public class SerialWANStatsDUnitTest extends WANTestBase {
 
     vm4.invoke(() -> WANTestBase.checkQueueStats("ln", 0, entries, entries, entries));
     vm4.invoke(() -> WANTestBase.checkBatchStats("ln", 1, true));
+    vm4.invoke(() -> WANTestBase.checkConflatedStats("ln", 0));
 
     // wait until queue is empty
     vm5.invoke(() -> await()
@@ -354,6 +355,7 @@ public class SerialWANStatsDUnitTest extends WANTestBase {
 
     vm4.invoke(() -> WANTestBase.checkQueueStats("ln", 0, entries, entries, entries));
     vm4.invoke(() -> WANTestBase.checkBatchStats("ln", 2, true, true));
+    vm4.invoke(() -> WANTestBase.checkConflatedStats("ln", 0));
 
     // wait until queue is empty
     vm5.invoke(() -> await()

In addition to the tests above, SerialWANPropagation_PartitionedRegionDUnitTest.testPartitionedSerialPropagationHA() fails with incorrectly incremented conflation stats if a similar check is introduced at the end of the test. Again, without the changes introduced by PR #4928, this modified test passes.

Issue Links

• fixes: GEODE-8320 SerialWANStatsDUnitTest.testReplicatedSerialPropagationHAWithGroupTransactionEvents is failiing
• links to: GitHub Pull Request #5313