[GEODE-8297] TcrMessage default timeout is set to 15ms, rather than 15 seconds

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.14.0
• Component/s: native client
• Assignee: Blake Bender
• Reporter: Blake Bender
• Created: 25/Jun/20 15:44
• Updated: 11/Dec/20 19:53
• Resolved: 06/Jul/20 19:00

Description

While analyzing a log from a bug report, I noticed a trace message from TcrConnection::sendData:

[debug <<deleted>> 123145454981120] before send len 99 sendTimeoutSec = 15000us checkConnected = 1 m_connected 1

 

It appears, from further digging, that we are indeed using a 15ms timeout for (at least) the 

USER_CREDENTIAL_MESSAGE.  This will happen for any message we don't explicitly set the timeout on before sending.  Potentially this is a cause for a lot of random network timeout failures.  Regardless of whether or not it's for sure causing problems, it's definitely wrong, by 3 orders of magnitude.  This needs to be set to the intended default of 15 seconds.

 

Issue Links

• links to: GitHub Pull Request #623