[GEODE-8261] Do not add proxyID to client interest list if it is null

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.12.1, 1.13.0, 1.14.0
• Component/s: client queues
• Assignee: Unassigned
• Reporter: Nabarun Nag
• Created: 16/Jun/20 19:02
• Updated: 10/Nov/20 23:13
• Resolved: 19/Jun/20 19:30

Description

• Sometime during shutdown proxyIDs can be null 
• Attempting to add this null value to data structures can cause NPE. For example the below mentioned code snippets may cause NPE if proxyID is null.

protected void addClientCQsAndInterestList(ClientUpdateMessageImpl msg,
      HAEventWrapper haEventWrapper, Map haContainer, String regionName) {    ClientProxyMembershipID proxyID = ((HAContainerWrapper) haContainer).getProxyID(regionName);
    if (proxyID != null) {
      if (haEventWrapper.getClientCqs() != null) {
        CqNameToOp clientCQ = haEventWrapper.getClientCqs().get(proxyID);
        if (clientCQ != null) {
          msg.addClientCqs(proxyID, clientCQ);
        }
      }      // This is a remote HAEventWrapper.
      // Add new Interested client lists.
      ClientUpdateMessageImpl clientMsg =
          (ClientUpdateMessageImpl) haEventWrapper.getClientUpdateMessage();
      if (clientMsg != null) {
        if (clientMsg.isClientInterestedInUpdates(proxyID)) {
          msg.addClientInterestList(proxyID, true);
        } else if (clientMsg.isClientInterestedInInvalidates(proxyID)) {
          msg.addClientInterestList(proxyID, false);
        }
      }
    }
  }

Issue Links

• links to: GitHub Pull Request #5251