Uploaded image for project: 'Geode'
  1. Geode
  2. GEODE-8261

Do not add proxyID to client interest list if it is null

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.12.1, 1.13.0, 1.14.0
    • Component/s: client queues
    • Labels:
      None

      Description

      • Sometime during shutdown proxyIDs can be nullĀ 
      • Attempting to add this null value to data structures can cause NPE. For example the below mentioned code snippets may cause NPE if proxyID is null.
      protected void addClientCQsAndInterestList(ClientUpdateMessageImpl msg,
            HAEventWrapper haEventWrapper, Map haContainer, String regionName) {    ClientProxyMembershipID proxyID = ((HAContainerWrapper) haContainer).getProxyID(regionName);
          if (proxyID != null) {
            if (haEventWrapper.getClientCqs() != null) {
              CqNameToOp clientCQ = haEventWrapper.getClientCqs().get(proxyID);
              if (clientCQ != null) {
                msg.addClientCqs(proxyID, clientCQ);
              }
            }      // This is a remote HAEventWrapper.
            // Add new Interested client lists.
            ClientUpdateMessageImpl clientMsg =
                (ClientUpdateMessageImpl) haEventWrapper.getClientUpdateMessage();
            if (clientMsg != null) {
              if (clientMsg.isClientInterestedInUpdates(proxyID)) {
                msg.addClientInterestList(proxyID, true);
              } else if (clientMsg.isClientInterestedInInvalidates(proxyID)) {
                msg.addClientInterestList(proxyID, false);
              }
            }
          }
        }
      
      

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              nnag Nabarun Nag

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment