[GEODE-8071] RebalanceCommand Should Use Daemon Threads

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.0, 1.9.0, 1.9.1, 1.9.2, 1.10.0, 1.11.0, 1.12.0
• Fix Version/s: 1.12.1, 1.13.0, 1.14.0
• Component/s: gfsh, management
• Labels: caching-applications pull-request-available
• Assignee: Juan Ramos
• Reporter: Juan Ramos
• Created: 05/May/20 15:59
• Updated: 27/Oct/20 11:11
• Resolved: 06/May/20 11:45

Description

The RebalanceCommand uses a non-daemon thread to execute its internal logic:

RebalanceCommand.java

ExecutorService commandExecutors = LoggingExecutors.newSingleThreadExecutor("RebalanceCommand", false);

The above prevents the locator from gracefully shutdown afterwards:

"RebalanceCommand1" #971 prio=5 os_prio=0 tid=0x00007f9664011000 nid=0x15905 waiting on condition [0x00007f9651471000]
   java.lang.Thread.State: WAITING (parking)
        at sun.misc.Unsafe.park(Native Method)
        - parking to wait for  <0x00000007308c36e8> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
        at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
        at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
        at java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
        at java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:748)

Issue Links

• links to: GitHub Pull Request #5054
• links to: GitHub Pull Request #5676