[GEODE-7930] Endpoint name truncated when exceeds 99 characters causing failed connections

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.13.0
• Component/s: native client
• Assignee: Jakov Varenina
• Reporter: Jakov Varenina
• Created: 31/Mar/20 06:51
• Updated: 10/Sep/20 15:52
• Resolved: 07/Apr/20 06:24

Description

When subscription is "enabled" in native client then the server endpoint name (host name + port) is truncated if exceeds 99 characters resulting with failed connections towards servers (see logs in attachment). When subscription is "disabled" everything worked fine for what I tested. Also I performed some tests with java client and haven't found such limitation on endpoint name length.

Endpoint name (e.g. server host name) + port is truncated within function addEP:

TcrEndpoint* ThinClientPoolDM::addEP(ServerLocation& serverLoc) {
  std::string serverName = serverLoc.getServerName();
  int port = serverLoc.getPort();
  char endpointName[100];
  std::snprintf(endpointName, 100, "%s:%d", serverName.c_str(), port);

  return addEP(endpointName);
}

Maximum length of FQDN according to RFC 2181:

The DNS itself places only one restriction on the particular labels
that can be used to identify resource records. That one restriction
relates to the length of the label and the full name. The length of
any one label is limited to between 1 and 63 octets. A full domain
name is limited to 255 octets (including the separators).

Due to above requirement the function addEP should not limit or truncate endpoint name.

Issue Links

• fixes: GEODE-8003 Unexpected error log in native client
• links to: GitHub Pull Request #588