[GEODE-7867] Add more unit tests to geode-tcp-server

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.13.0
• Component/s: membership
• Assignee: Bruce J Schuchardt
• Reporter: Bruce J Schuchardt
• Created: 10/Mar/20 21:29
• Updated: 10/Sep/20 15:53
• Resolved: 13/Mar/20 22:42

Description

This new module has few tests and relies mostly on geode-core and other modules to test its functionality.

HostAndPort has tests for only 5 of its 14 methods.
ClientSocketCreatorImpl is untested
TcpClient has only 50% code coverage.
TcpServer's run() method has error handling that is untested.

I counted tests from geode-membership when running this analysis. If you leave out that module the numbers are even worse.

Issue Links

• links to: GitHub Pull Request #4796