[GEODE-785] Refactor repetitive comparison/loop code in CompiledIn.evaluate

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.0-incubating.M2
• Component/s: querying
• Assignee: Jason Huynh
• Reporter: Jason Huynh
• Created: 18/Jan/16 20:12
• Updated: 12/Apr/16 05:59
• Resolved: 20/Jan/16 18:15

Description

In CompiledIn.evaluate we can see repetitive loops, each one differing only in the cast to a specific array type. For example:
// handle each type of primitive array
if (evalColln instanceof long[]) {
long[] a = (long[])evalColln;
for (int i = 0; i < a.length; i++) {
Object e = Long.valueOf(a[i]);
if (TypeUtils.compare(evalElm, e, TOK_EQ).equals(Boolean.TRUE))

{ return Boolean.TRUE; }
}
return Boolean.FALSE;
}

if (evalColln instanceof double[]) {
double[] a = (double[])evalColln;
for (int i = 0; i < a.length; i++) {
Object e = Double.valueOf(a[i]);
if (TypeUtils.compare(evalElm, e, TOK_EQ).equals(Boolean.TRUE)) { return Boolean.TRUE; }

}
return Boolean.FALSE;
}

We should be able to write a test to exercise this code and then write a single loop that handles all object thypes as the comparison is actually done by the TypeUtils.compare() method.