[GEODE-7832] Remove connection "send semaphores" from DirectChannel

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.13.0
• Component/s: membership
• Labels: GeodeCommons
• Assignee: Juan Ramos
• Reporter: Bruce J Schuchardt
• Created: 28/Feb/20 23:15
• Updated: 10/Sep/20 15:51
• Resolved: 04/Mar/20 09:20

Description

Remove the acquiredSendSemaphore/acquireGroupSendSemaphore and related methods from DirectChannel/TCPConduit code. Connection.isReaderThread() and associated makeReaderThread() methods can also be deleted because they're only used by the semaphore code.

These semaphores only constrain messaging if you set a couple of undocumented system properties, p2p.maxGroupSenders and p2p.maxConnectionSenders to some small value. These are (MAX_INT / 2) by default.

Issue Links

• links to: GitHub Pull Request #4754