[GEODE-7789] Performance Degradation on Servers with Client Subscription Introduced in GEODE-7358

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.11.0
• Fix Version/s: 1.12.0, 1.13.0
• Component/s: client queues, client/server
• Labels: GeodeCommons
• Assignee: Ernest Burghardt
• Reporter: Juan Ramos
• Created: 11/Feb/20 12:29
• Updated: 30/Mar/20 23:33
• Resolved: 13/Feb/20 10:07

Description

On clusters with pool subscriptions enabled, a performance degradation was introduced by GEODE-7358 for regular cache operations.
The InternalDistributedMember.getDurableClientAttributes() method is indirectly invoked by the methods hashCode() and equals() within the ClientProxyMembershipID class, which is stored in several Java Collection classes across the product (including different types of Map instances).
Prior to GEODE-7358 the DurableClientAttributes class instance was cached within the NetMember class, but now is created every time the method is invoked, resulting in a performance penalty for regular cache operations on servers with subscription enabled (not only extra garbage, the constructor itself also does some string manipulation).
Using one of our internal testing scenarios and a java profiler we detected that we create ~24 instances of DurableClientAttributes using Geode 1.10, but ~ 404.037.243 instances using the latest develop branch (screenshots attached).

Issue Links

• links to: GitHub Pull Request #4687