[GEODE-7623] AlertingAction thread local looks like it will no longer have any effect

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.12.0
• Component/s: logging, membership
• Assignee: Ernest Burghardt
• Reporter: Dan Smith
• Created: 24/Dec/19 19:07
• Updated: 30/Mar/20 23:34
• Resolved: 02/Jan/20 20:12

Description

From code inspection, it looks like the changes in dffcb944 have made the AlertingAction class effectively useless.

The class has a thread local that is set when we start sending an alert. But dffcb944 changed the alert process such that shortly after the thread local is set, the bulk of the alerting logic happens in a separate thread, without the thread local, in ClusterAlertMessaging.sendAlert.

Therefore, this thread local has no effect. If this behavior was previously useful, we need to set the thread local inside this new executor thread, perhaps? Or find some other way to prevent the executor from triggering new alerts?

Issue Links

• links to: GitHub Pull Request #4550