Uploaded image for project: 'Geode'
  1. Geode
  2. GEODE-7623

AlertingAction thread local looks like it will no longer have any effect

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.12.0
    • Component/s: logging, membership
    • Labels:
      None

      Description

      From code inspection, it looks like the changes in dffcb944 have made the AlertingAction class effectively useless.

      The class has a thread local that is set when we start sending an alert. But dffcb944 changed the alert process such that shortly after the thread local is set, the bulk of the alerting logic happens in a separate thread, without the thread local, in ClusterAlertMessaging.sendAlert.

      Therefore, this thread local has no effect. If this behavior was previously useful, we need to set the thread local inside this new executor thread, perhaps? Or find some other way to prevent the executor from triggering new alerts?

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                echobravo Ernest Burghardt
                Reporter:
                upthewaterspout Dan Smith
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m