[GEODE-7486] IndexManager is not consistent

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.12.0
• Component/s: querying
• Labels: GeodeCommons
• Assignee: Ernest Burghardt
• Reporter: Juan Ramos
• Created: 21/Nov/19 10:23
• Updated: 30/Mar/20 23:34
• Resolved: 22/Nov/19 13:50

Description

While working on GEODE-7351, I've found that the current IndexManager behaviour is not consistent:

• If there's an exception thrown while adding an index mapping, we eat the exception, log an useless warning, and mark the index as invalid.
• If there's an exception thrown while removing an index mapping, we re-throw the exception and leave the index as it is, even though it should be marked as invalid as well.

The IndexManager should behave consistently and mark the index as invalid in both situations, clearly logging what went wrong while adding/removing the mapping.

Issue Links

• blocks: GEODE-7351 Verify constraints when changing the MethodInvocationAuthorizer
• is a child of: GEODE-6983 Epic for OQL Method Invocation Security
• links to: GitHub Pull Request #4353