[GEODE-7466] HARegionQueueTest queuePutElidesSequenceIdLowerThanOrEqualToLastSeenSequenceId can throw a NullPointerException if the CacheClientNotifier instance is set

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.12.0
• Component/s: tests
• Assignee: Ernest Burghardt
• Reporter: Barrett Oglesby
• Created: 16/Nov/19 00:52
• Updated: 30/Mar/20 23:32
• Resolved: 19/Nov/19 22:09

Description

Testing has shown this NPE can occur:

java.lang.NullPointerException
    at java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936)
    at org.apache.geode.internal.cache.tier.sockets.CacheClientNotifier.getClientProxy(CacheClientNotifier.java:1197)
    at org.apache.geode.internal.cache.ha.HARegionQueue$DispatchedAndCurrentEvents.putObject(HARegionQueue.java:3023)
    at org.apache.geode.internal.cache.ha.HARegionQueue.basicPut(HARegionQueue.java:679)
    at org.apache.geode.internal.cache.ha.HARegionQueue.put(HARegionQueue.java:631)
    at org.apache.geode.internal.cache.ha.HARegionQueueTest.queuePutElidesSequenceIdLowerThanOrEqualToLastSeenSequenceId(HARegionQueueTest.java:119)

HARegionQueue.java:3023 is here:

                            CacheClientNotifier ccn = CacheClientNotifier.getInstance();
                            if (ccn != null) {
HARegionQueue.java:3023 ->    ccn.getClientProxy(owningQueue.clientProxyID).getStatistics().incMessagesFailedQueued();
                            }

The HARegionQueueTest does not create a CacheClientNotifier, so it seems like its created in another test and that test affects this one.

If a CacheClientNotifier is created in this test, then the same NPE is thrown because owningQueue.clientProxyID is null.

Issue Links

• links to: GitHub Pull Request #4338