[GEODE-7299] Memory leak in PdxInstanceImpl::updatePdxStream

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.12.0
• Component/s: native client
• Assignee: Unassigned
• Reporter: Blake Bender
• Created: 15/Oct/19 16:47
• Updated: 27/Nov/19 16:56
• Resolved: 27/Nov/19 16:56

Description

The `PdxInstanceImpl::updatePdxStream` method assigns the result of `DataInput::getBufferCopy` to its `m_buffer` member variable, but `m_buffer` is deleted by `PdxInstanceImpl` in its destructor, implying that `PdxInstanceImpl` owns the pointer, which means, in this case, that the existing `m_buffer`, if there is one, is leaked in this call.  We discovered that `updatePdxStream` is called on every put of a Pdx type, so in a tight loop with a lot of puts we are potentially leaking a lot of memory.

 

Repro steps:

Run the soon-to-be-implemented `LeakPdxMemory` test in the NC integration test suite.  Test will attempt to do a large number of puts of a large Pdx object, and look for an out of memory exception.

 

Expected result:

Test passes

 

Actual result:

Test fails.

Issue Links

• links to: GitHub Pull Request #537