[GEODE-7291] Cluster and Member micrometer common tags should not be used with empty values

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.11.0
• Fix Version/s: 1.11.0
• Component/s: statistics
• Assignee: Kirk Lund
• Reporter: Kirk Lund
• Created: 14/Oct/19 18:21
• Updated: 30/Dec/19 18:49
• Resolved: 21/Oct/19 22:41

Description

Creating tags without values is something that Micrometer recommends against doing. With our common tags we need to consider the implications of adding them outside of a server/locator member of a cluster.

Given I create a cache without a member name 
When I add a meterregistry to that cache
Then I should not see the member common tag:
- member
And I should see the following common tags:
- cluster
- host
- member_type

Given I create a clientcache through Java
When I add a meterregistry to that cache
Then I should not see the following common tags:
- cluster
And I should see the following common tags:
- host
- member
- member_type

Issue Links

• links to: GitHub Pull Request #4156