Uploaded image for project: 'Geode'
  1. Geode
  2. GEODE-7235

Disable new Clang warnings to fix build for now

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.11.0
    • native client
    • None

    Description

      Apple pushed an XCode update a couple of days ago to version `

      Apple clang version 11.0.0 (clang-1100.0.33.8)`.  This version flags some new warnings in our code, and since we have warnings-as-errors turned on we blow up.  Fixing these warnings is non-trivial, so we need to disable them in the top-level CMakeLists.txt and file another Jira issue to do the real fix.

      • Steps to repro:

      Sync up to the latest `develop` branch of Native Client on a Mac and build

      • Expected Result:

      Geode Native builds, and produces our libraries

      • Actual Result:

      Clang warns about "implicitly deleted copy/move ctors declared as default" in a product header, gives a warning about UTF-8 string literals in test code, then build fails.  

       

      Attachments

        Activity

          People

            Unassigned Unassigned
            bbender Blake Bender
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 40m
                1h 40m