[GEODE-7110] Improve Integration test coverage for Tomcat session state module

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.12.0
• Component/s: http session, tests
• Labels: GeodeCommons
• Assignee: Ernest Burghardt
• Reporter: Benjamin P Ross
• Created: 21/Aug/19 21:20
• Updated: 30/Mar/20 23:33
• Resolved: 11/Nov/19 20:01

Description

Our Integration test coverage is significantly lacking for the Tomcat session state module. This story aims to improve test coverage of that module.

Write Integration tests for the following classes:

• DeltaSessionAttributeEventBatch
• DeltaSessionDestroyAttributeEvent
• DeltaSessionStatistics
• DeltaSessionUpdateAttributeEvent
• AbstractSessionCache
• ClientServerSessionCache
• CommitSessionValve
• DeltaSession
• DeltaSessionFacade
• DeltaSessionManager
• JvmRouteBinderValve
• PeerToPeerSessionCache
• SessionExpirationCacheListener
• TouchReplicatedRegionEntriesFunction
• TouchPartitionedRegionEntriesFunction

Currently the only integration tests the module has are util tests and Tomcat6Session testing. Since tomcat 6 is deprecated and we have support as far as Tomcat 9 in the product we should add similar tests for Tomcat 7-9. Additionally, this testing seems to be peer to peer so we should consider creating a client-server version as well.

Issue Links

• links to: GitHub Pull Request #4271