Uploaded image for project: 'Geode'
  1. Geode
  2. GEODE-7004

Optimize ResourcePermission constructor

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.10.0
    • security

    Description

      PartitionedPutBenchmark with Security Manager enabled shows a performance degradation:

      org.apache.geode.benchmark.tests.PartitionedPutBenchmark
                    average ops/second  Baseline:    313077.71  Test:    303114.88  Difference:   -3.2%
             ops/second standard error  Baseline:       714.84  Test:       511.86  Difference:  -28.4%
         ops/second standard deviation  Baseline:     12360.75  Test:      8850.96  Difference:  -28.4%
            YS 99th percentile latency  Baseline:      2901.00  Test:      2802.00  Difference:   -3.4%
                        median latency  Baseline:   1586175.00  Test:   1613823.00  Difference:   +1.7%
               90th percentile latency  Baseline:   2289663.00  Test:   2303999.00  Difference:   +0.6%
               99th percentile latency  Baseline:   3213311.00  Test:   3289087.00  Difference:   +2.4%
             99.9th percentile latency  Baseline:  72220671.00  Test:  61636607.00  Difference:  -14.7%
                       average latency  Baseline:   1838420.24  Test:   1898668.38  Difference:   +3.3%
            latency standard deviation  Baseline:   3840098.38  Test:   3827737.37  Difference:   -0.3%
                latency standard error  Baseline:       396.30  Test:       401.43  Difference:   +1.3%
      
      

      In stats, we noticed a higher CPU utilization and less puts.

       

      When Security Manager is enabled, every put operation calls IntegratedSecurityService.authorize method, which creates new ResourcePermission object. Every execution of ResourcePermission constructor takes 5 ms. With the optimization, ResourcePermission constructor execution takes less than 0.1 ms.

      Attachments

        Issue Links

          Activity

            People

              kaslami Kamilla Aslami
              kaslami Kamilla Aslami
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h