[GEODE-6908] Some retry operation from client did not set setPossibleDuplicate in event

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.10.0
• Labels: GeodeCommons
• Assignee: Xiaojian Zhou
• Reporter: Xiaojian Zhou
• Created: 25/Jun/19 18:12
• Updated: 26/Sep/19 18:03
• Resolved: 28/Jun/19 18:45

Description

I fixed a bug GEODE-6899, where the retried UPDATE did not set event the version tag found from previous try.

I searched other code and found there's one more place:
basicBridgeRemove() should also add following lines like in basicBridgeDestroy:

// if this is a replayed operation we may already have a version tag
event.setVersionTag(clientEvent.getVersionTag());
event.setPossibleDuplicate(clientEvent.isPossibleDuplicate());

BTW, basicBridgeDestroy(), basicBridgeUpdateVersionStamp(), basicBridgeInvalidate() called
event.setVersionTag(clientEvent.getVersionTag()); but they did not call "event.setPossibleDuplicate(clientEvent.isPossibleDuplicate());"

I think it's better to keep all the code the same.

Issue Links

• links to: GitHub Pull Request #3755