Uploaded image for project: 'Geode'
  1. Geode
  2. GEODE-6797

Possibility for missing dependencies in session state modules

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.10.0
    • Component/s: build
    • Labels:

      Description

      It was found that the AppServer module in Geode 1.9.0 release package is missing a dependency, specifically `geode-modules-1.9.0`.  This appears to be due to the way we are zipping the module and specifying its dependencies in Gradle.

      From Dan Smith:

       

      The basic issue is that this task includes the module jar in the zip in weird way, but doesn't declare the jar task as a dependency (in geode-modules-assembly/build.gradle):
      
      task distAppServer(type: Zip, dependsOn: [':extensions:geode-modules-session:jar',
       ':extensions:geode-modules-session-internal:jar',
       ':extensions:geode-modules-tomcat7:jar',
       ':extensions:geode-modules-tomcat8:jar',
       ':extensions:geode-modules-tomcat9:jar']) {
       baseName = moduleBaseName
       classifier = "AppServer"
      into('lib') {
       from getJarArtifact(':extensions:geode-modules-session')
       from getJarArtifact(':extensions:geode-modules-session-internal')
       from getJarArtifact(':extensions:geode-modules')
       from configurations.slf4jDeps
       }
      
      So I think it's somewhat indeterminant if any given build contains that jar in the zip. If we run the distributedTest on that particular build, we would catch the issue, but that's not how our build works (at least for geode releases).
      

       

        Attachments

          Activity

            People

            • Assignee:
              rmcmahon Ryan McMahon
              Reporter:
              rmcmahon Ryan McMahon
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 40m
                40m