[GEODE-6759] Prevent pool destruction if it's still in use and fix NPE in function execution

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.10.0
• Component/s: client/server
• Labels: GeodeCommons
• Assignee: Juan Ramos
• Reporter: Juan Ramos
• Created: 08/May/19 23:46
• Updated: 26/Sep/19 18:02
• Resolved: 17/May/19 15:47

Description

A NullPointerException can be thrown on client side if the application executes a function on a pool that has been destroyed.
The following code reproduces the issue:

ClientCache clientCache = new ClientCacheFactory().create();
PoolManager.createFactory().addLocator(InetAddress.getLocalHost().getHostName(), locator.getPort()).create("poolOne");

Region region = clientCache.createClientRegionFactory(PROXY).setPoolName("poolOne").create("TestRegion");
PoolManagerImpl.getPMI().unregister(PoolManager.find("poolOne"));

FunctionService.onRegion(region).execute(testFunction).getResult();

The problem is that we don't verify whether the Pool is currently being used or not within the unregister method. The following should be done:

1. Don't allow the user to unregister the pool when at least one region is associated to it.
2. Throw a meaningful exception if the pool can't be found before executing the function.

Issue Links

• links to: GitHub Pull Request #3569