[GEODE-6279] CI: PR Test results URI is valid but unintentionally mangled. Many scripts reproduce effort.

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.9.0
• Labels: pull-request-available
• Assignee: Patrick Rhomberg
• Reporter: Patrick Rhomberg
• Created: 15/Jan/19 21:20
• Updated: 24/Apr/19 22:23
• Resolved: 16/Jan/19 17:33

Description

For instance, the test run here contains the following output in the archive_results step:

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=  Test Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-{"pr":"3032","commit":"a9a03f033e90b39aceab07b56919e6a4fef1e43d","committed":"2019-01-10T20:13:25Z"}/test-results/upgradeTest/1547153318/
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

This is a consequence of the diff-set for GEODE-6259 using the concourse version as the (Concourse) source of truth for versioning and expecting the version file to only contain the version string.

Another underlying issue is that many of these scripts are (a) used in both the main pipeline as well as the PR pipeline and (b) nearly-but-imperfectly duplicate a great deal fo work between each script. These common tasks should be unified to a shared utilities that can be accessed by any of our scripts so that these pitfalls do not snare future developers.

Issue Links

• links to: GitHub Pull Request #3081