Uploaded image for project: 'Geode'
  1. Geode
  2. GEODE-5997

FastLogger optimization should work without using isEnabled clause

    XMLWordPrintableJSON

    Details

    • Type: Wish
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: logging

      Description

      Geode logger statements at debug or trace level currently have isDebugEnabled and isTraceEnabled clauses which are overridden by FastLogger to improve performance of disabled log statements.

      If FastLogger is changed to override every method defined in the ExtendedLogger interface, then we can delete all isDebugEnabled and isTraceEnabled clauses.

      It would be ideal to include new JMH benchmarks with any changes involving FastLogger.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                klund Kirk Lund
                Reporter:
                klund Kirk Lund
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 4h
                  4h