[GEODE-5953] TXStateProxyImpl target needs to be set to local member if it contains TXState

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.0
• Fix Version/s: 1.8.0
• Component/s: transactions
• Labels: pull-request-available
• Assignee: Eric Shu
• Reporter: Eric Shu
• Created: 29/Oct/18 23:17
• Updated: 31/Oct/18 21:20
• Resolved: 31/Oct/18 19:37

Description

If target is not set earlier, it will be set in function execution code. It could cause issue when rebalance occurs during function execution by setting target to another node when the local member already hosts the transaction. If target was set earlier, the following code can detect it and throw TransactionDataRebalancedException.

public void validateExecution(Function function, Set targetMembers) {
InternalCache cache = pr.getGemFireCache();
if (cache.getTxManager().getTXState() != null) {
if (targetMembers.size() > 1)

{ throw new TransactionException( "Function inside a transaction cannot execute on more than one node"); }

else {
assert targetMembers.size() == 1;
DistributedMember funcTarget = (DistributedMember) targetMembers.iterator().next();
DistributedMember target = cache.getTxManager().getTXState().getTarget();
if (target == null)

{ cache.getTxManager().getTXState().setTarget(funcTarget); }

else if (!target.equals(funcTarget))

{ throw new TransactionDataRebalancedException( String.format( "Function execution is not colocated with transaction. The transactional data is hosted on node %s, but you are trying to target node %s", target, funcTarget)); }

}
}
cache.getInternalResourceManager().getHeapMonitor().checkForLowMemory(function, targetMembers);
}

Issue Links

• links to: GitHub Pull Request #2746