[GEODE-5922] SerialGatewaySenderQueue concurrency is poorly implemented

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Component/s: wan
• Labels: pull-request-available
• Assignee: Bruce J Schuchardt
• Reporter: Bruce J Schuchardt
• Created: 24/Oct/18 20:24
• Updated: 22/Jan/21 18:16
• Resolved: 06/Jan/21 22:13

Description

This class uses synchronization on the queue to limit access to one put at a time. Synchronization isn't a fair locking mechanism so threads can be blocked trying to add events to the queue while other more recent events get the lock and insert their events. This causes inconsistent latency which I've observed being as long as 30 seconds, causing client connections to be shut down by the ClientHealthMonitor.

Issue Links

• is related to: GEODE-8861 Performance degradation in serial WAN sender queue size and update latency
• links to: GitHub Pull Request #2705
• links to: GitHub Pull Request #5870