[GEODE-5702] AbstractPeerTXRegionStub does not need to wrap a specific TransactionException

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.0
• Fix Version/s: 1.8.0
• Component/s: transactions
• Labels: pull-request-available
• Assignee: Eric Shu
• Reporter: Eric Shu
• Created: 06/Sep/18 18:17
• Updated: 07/Sep/18 19:27
• Resolved: 06/Sep/18 21:21

Description

When handling fetchKeys, we should just send a specific TransactionException instead of wrap it to a general TransactionException.

org.apache.geode.cache.TransactionException: org.apache.geode.cache.TransactionDataNodeHasDepartedException: Node departed while fetching keys, caused by org.apache.geode.cache.TransactionDataNodeHasDepartedException: Node departed while fetching keys
	at org.apache.geode.internal.cache.tx.AbstractPeerTXRegionStub.getRegionKeysForIteration(AbstractPeerTXRegionStub.java:53)
	at org.apache.geode.internal.cache.TXStateStub.getRegionKeysForIteration(TXStateStub.java:678)
	at org.apache.geode.internal.cache.TXStateStub.getRegionKeysForIteration(TXStateStub.java:45)
	at org.apache.geode.internal.cache.TXStateProxyImpl.getRegionKeysForIteration(TXStateProxyImpl.java:770)
	at org.apache.geode.internal.cache.EntriesSet$EntriesIterator.createIterator(EntriesSet.java:213)
	at org.apache.geode.internal.cache.EntriesSet$EntriesIterator.<init>(EntriesSet.java:117)
	at org.apache.geode.internal.cache.EntriesSet.iterator(EntriesSet.java:83)
	at org.apache.geode.internal.cache.tier.sockets.command.KeySet.fillAndSendKeySetResponseChunks(KeySet.java:188)
	at org.apache.geode.internal.cache.tier.sockets.command.KeySet.cmdExecute(KeySet.java:141)
	at org.apache.geode.internal.cache.tier.sockets.BaseCommand.execute(BaseCommand.java:158)
	at org.apache.geode.internal.cache.tier.sockets.ServerConnection.doNormalMsg(ServerConnection.java:869)
	at org.apache.geode.internal.cache.tier.sockets.OriginalServerConnection.doOneMessage(OriginalServerConnection.java:77)
	at org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1248)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$4$1.run(AcceptorImpl.java:644)
	at java.lang.Thread.run(Thread.java:748)
Caused by: org.apache.geode.cache.TransactionDataNodeHasDepartedException: Node departed while fetching keys
	at org.apache.geode.internal.cache.tx.RemoteFetchKeysMessage$FetchKeysResponse.waitForKeys(RemoteFetchKeysMessage.java:430)
	at org.apache.geode.internal.cache.tx.AbstractPeerTXRegionStub.getRegionKeysForIteration(AbstractPeerTXRegionStub.java:44)
	... 16 more

Issue Links

• links to: GitHub Pull Request #2430