[GEODE-5624] JTA transaction does not clean up TXState due to IllegalMonitorStateException

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.0
• Fix Version/s: 1.7.0
• Component/s: transactions
• Assignee: Eric Shu
• Reporter: Eric Shu
• Created: 23/Aug/18 16:32
• Updated: 03/Oct/18 21:37
• Resolved: 28/Aug/18 20:27

Description

When server has different threads handling JTA beforeCompletion and afterCompletion, IllegalMonitorStateException can be thrown when release locks held. This causes the TXState not being cleaned up.

java.lang.IllegalMonitorStateException: attempt to unlock read lock, not locked by current thread
        at java.util.concurrent.locks.ReentrantReadWriteLock$Sync.unmatchedUnlockException(ReentrantReadWriteLock.java:444)
        at java.util.concurrent.locks.ReentrantReadWriteLock$Sync.tryReleaseShared(ReentrantReadWriteLock.java:428)
        at java.util.concurrent.locks.AbstractQueuedSynchronizer.releaseShared(AbstractQueuedSynchronizer.java:1341)
        at java.util.concurrent.locks.ReentrantReadWriteLock$ReadLock.unlock(ReentrantReadWriteLock.java:881)
        at org.apache.geode.internal.util.concurrent.StoppableReentrantReadWriteLock$StoppableReadLock.unlock(StoppableReentrantReadWriteLock.java:144)
        at org.apache.geode.internal.cache.locks.TXLockServiceImpl.releaseRecoveryReadLock(TXLockServiceImpl.java:275)
        at org.apache.geode.internal.cache.locks.TXLockServiceImpl.release(TXLockServiceImpl.java:240)
        at org.apache.geode.internal.cache.TXLockRequest.releaseDistributed(TXLockRequest.java:109)
        at org.apache.geode.internal.cache.TXLockRequest.cleanup(TXLockRequest.java:142)
        at org.apache.geode.internal.cache.TXState.cleanup(TXState.java:870)
        at org.apache.geode.internal.cache.TXState.commit(TXState.java:514)
        at org.apache.geode.internal.cache.TXState.doAfterCompletion(TXState.java:1103)
        at org.apache.geode.internal.cache.TXState.afterCompletion(TXState.java:1084)
        at org.apache.geode.internal.cache.TXStateProxyImpl.afterCompletion(TXStateProxyImpl.java:452)
        at org.apache.geode.internal.cache.tier.sockets.command.TXSynchronizationCommand.cmdExecute(TXSynchronizationCommand.java:140)
        at org.apache.geode.internal.cache.tier.sockets.BaseCommand.execute(BaseCommand.java:158)
        at org.apache.geode.internal.cache.tier.sockets.ServerConnection.doNormalMsg(ServerConnection.java:869)
        at org.apache.geode.internal.cache.tier.sockets.OriginalServerConnection.doOneMessage(OriginalServerConnection.java:77)
        at org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1248)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$4$1.run(AcceptorImpl.java:645)
        at java.lang.Thread.run(Thread.java:745)