[GEODE-5495] Double decrement of HAEventWrapper ref count due to race between QRM and DestroyRQ

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.0
• Component/s: client queues
• Labels: pull-request-available
• Assignee: Ryan McMahon
• Reporter: Ryan McMahon
• Created: 30/Jul/18 17:25
• Updated: 03/Oct/18 21:38
• Resolved: 03/Aug/18 16:42

Description

When a client disconnects due to network issues e.g. SocketTimeoutExceptions we will destroy the HARegionQueue for that client. As part of that process, we decrement the reference count on the HAEventWrappers used by that client in the HAContainer.

However, we may still be receiving queue removal messages for that client which results in a decrement of those same HAEventWrappers. This double decrementing can result in premature removal of the HAEventWrapper from the HAContainer even though other clients still need it.

We need to prevent this double decrementing and premature removal, perhaps through synchronization between the destroyRQ() logic and queue removal messages.

Issue Links

• links to: GitHub Pull Request #2248